Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document disabling of GC operations/maintenance queue #440

Open
MrChrisW opened this issue Sep 24, 2018 · 3 comments
Open

Document disabling of GC operations/maintenance queue #440

MrChrisW opened this issue Sep 24, 2018 · 3 comments

Comments

@MrChrisW
Copy link
Member

@MrChrisW MrChrisW commented Sep 24, 2018

Overview

The question of whether backup-utils stops maintenance/GC operations on GHE comes up frequently, often the easiest way to confirm this, is to look at the self-documenting code + comments:

# The location of the file used to disable GC operations on the remote side.
: ${SYNC_IN_PROGRESS_FILE:="$GHE_REMOTE_DATA_USER_DIR/repositories/.sync_in_progress"}

# Touch the sync-in-progress file, disabling GC operations, and wait for all
# active GC processes to finish on the remote side.
echo "
set -e
sudo -u git touch '$SYNC_IN_PROGRESS_FILE'

Problem

Viewing the code to determine the application behaviour isn't efficient.

Solution

Document the fact maintenance/GC operations are paused when backup-utils is running. Preferably in the FAQ: https://github.com/github/backup-utils/blob/master/docs/faq.md

@snh
Copy link
Member

@snh snh commented Sep 24, 2018

Document the fact maintenance/GC operations are paused when backup-utils is running.

Just to clarify, we only pause these during the repositories stage of a backup and restore, and the storage stage of a backup, not the entire backup and restore process.

Specifically, the following scripts make use of ghe-gc-disable and ghe-gc-enable:

  • ghe-backup-storage
  • ghe-backup-repositories
  • ghe-restore-repositories-rsync
  • ghe-restore-repositories
@lildude
Copy link
Member

@lildude lildude commented Sep 24, 2018

Document the fact maintenance/GC operations are paused when backup-utils is running. Preferably in the FAQ: https://github.com/github/backup-utils/blob/master/docs/faq.md

👍 I'm in the process of adding a few other items to the FAQ and will add this.

@lildude lildude self-assigned this Sep 24, 2018
@MrChrisW
Copy link
Member Author

@MrChrisW MrChrisW commented Feb 22, 2019

Friendly bump 🏗

@lildude lildude removed their assignment Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.