Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gitpod config #10728

Merged
merged 7 commits into from Mar 9, 2020
Merged

ci: add gitpod config #10728

merged 7 commits into from Mar 9, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Mar 3, 2020

this commit adds support for Gitpod.io, a free automated
dev environment that makes contributing and generally working on GitHub
projects much easier. It allows anyone to start a ready-to-code dev
environment for any branch, issue and pull request with a single click.

Description

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
this commit adds support for Gitpod.io, a free automated
dev environment that makes contributing and generally working on GitHub
projects much easier. It allows anyone to start a ready-to-code dev
environment for any branch, issue and pull request with a single click.
MajesticPotatoe
MajesticPotatoe previously requested changes Mar 3, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Given that this is a mono-repo, a simple yarn and yarn build will suffice as start command wont do much, possibly also add in a copy command for the Playground.template.vue -> Playground.vue in the vuetify/dev folder.

Will review with team if this is something we would like to add.

@MajesticPotatoe MajesticPotatoe dismissed their stale review Mar 6, 2020

resolved

MajesticPotatoe
MajesticPotatoe previously requested changes Mar 6, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

@MajesticPotatoe MajesticPotatoe dismissed their stale review Mar 6, 2020

obsolete

@MajesticPotatoe MajesticPotatoe changed the title feat: add gitpod config ci: add gitpod config Mar 6, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

After consideration with the team, we have decided to just accept the addition of the config for this service. thank you for your contribution.

@MajesticPotatoe MajesticPotatoe merged commit 44e8a7d into vuetifyjs:master Mar 9, 2020
1 check was pending
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants