add backtracking for solve magic sequence #4571

Mikhael-J · 2021-07-25T13:19:50Z

Describe your change:add a algorithm using backtracking for solve magic sequence

[x ] Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-07-25T13:19:53Z

backtracking/magic_sequence.py

+import copy
+
+
+def backtrack(n: int, sequence: list[any], res: list[int] = [], depth: int = 0):


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function backtrack

Please provide return type hint for the function: backtrack. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: n

ghost · 2021-07-25T13:19:54Z

backtracking/magic_sequence.py

+    return res
+
+
+def check_magic_sequence(sequence: list[int]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function check_magic_sequence

ghost · 2021-07-25T13:19:54Z

backtracking/magic_sequence.py

+    return False
+
+
+def somme_elem_lower_to_len(sequence: list[any]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function somme_elem_lower_to_len

ghost · 2021-07-25T13:19:54Z

backtracking/magic_sequence.py

+
+if __name__ == "__main__":
+    try:
+        nbElement = int(sys.argv[1])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: nbElement

ghost · 2021-07-25T13:19:54Z

backtracking/magic_sequence.py

+        print(
+            "no first arg given so number of element is initialized to 4 because it's the first one to give a answer"
+        )
+        nbElement = 4


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: nbElement

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-07-25T13:26:08Z

backtracking/magic_sequence.py

+import copy
+
+
+def backtrack(


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function backtrack

ghost · 2021-07-25T13:26:08Z

backtracking/magic_sequence.py

+
+
+def backtrack(
+    n: int, sequence: list[any], res: list[int] = [], depth: int = 0


Please provide descriptive name for the parameter: n

ghost · 2021-07-25T13:26:08Z

backtracking/magic_sequence.py

+    return res
+
+
+def check_magic_sequence(sequence: list[int]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function check_magic_sequence

ghost · 2021-07-25T13:26:09Z

backtracking/magic_sequence.py

+    return False
+
+
+def somme_elem_lower_to_len(sequence: list[any]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function somme_elem_lower_to_len

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-07-25T13:37:43Z

backtracking/magic_sequence.py

+import copy
+
+
+def backtrack(


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function backtrack

ghost · 2021-07-25T13:37:43Z

backtracking/magic_sequence.py

+    return res
+
+
+def check_magic_sequence(sequence: list[int]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function check_magic_sequence

ghost · 2021-07-25T13:37:43Z

backtracking/magic_sequence.py

+    return False
+
+
+def somme_elem_lower_to_len(sequence: list[any]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function somme_elem_lower_to_len

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2021-07-25T13:43:08Z

backtracking/magic_sequence.py

+import copy
+
+
+def backtrack(


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function backtrack

ghost · 2021-07-25T13:43:08Z

backtracking/magic_sequence.py

+    return res
+
+
+def check_magic_sequence(sequence: list[int]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function check_magic_sequence

ghost · 2021-07-25T13:43:09Z

backtracking/magic_sequence.py

+    return False
+
+
+def somme_elem_lower_to_len(sequence: list[any]) -> bool:


As there is no test file in this pull request nor any test function or class in the file backtracking/magic_sequence.py, please provide doctest for the function somme_elem_lower_to_len

stale · 2021-08-28T16:54:07Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-09-07T05:13:26Z

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

add backtracking for solve magic sequence

7b41324

ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jul 25, 2021

ghost reviewed Jul 25, 2021

View reviewed changes

ghost added the awaiting reviews This PR is ready to be reviewed label Jul 25, 2021

Update magic_sequence.py

a0207db

ghost removed the require type hints https://docs.python.org/3/library/typing.html label Jul 25, 2021

ghost reviewed Jul 25, 2021

View reviewed changes

Update magic_sequence.py

cf4b6f6

ghost removed the require descriptive names This PR needs descriptive function and/or variable names label Jul 25, 2021

ghost reviewed Jul 25, 2021

View reviewed changes

Update magic_sequence.py

1528944

ghost reviewed Jul 25, 2021

View reviewed changes

Update magic_sequence.py

e441099

ghost removed the require tests Tests [doctest/unittest/pytest] are required label Jul 25, 2021

Update magic_sequence.py

07df86b

ghost added the tests are failing Do not merge until tests pass label Jul 27, 2021

stale bot added the stale Used to mark an issue or pull request stale. label Aug 28, 2021

stale bot closed this Sep 7, 2021

		import copy


		def backtrack(n: int, sequence: list[any], res: list[int] = [], depth: int = 0):

		return res


		def check_magic_sequence(sequence: list[int]) -> bool:

		return False


		def somme_elem_lower_to_len(sequence: list[any]) -> bool:



		def backtrack(
		n: int, sequence: list[any], res: list[int] = [], depth: int = 0

Uh oh!

add backtracking for solve magic sequence #4571

add backtracking for solve magic sequence #4571

Uh oh!

Conversation

Mikhael-J commented Jul 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:add a algorithm using backtracking for solve magic sequence

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Aug 28, 2021

Uh oh!

stale bot commented Sep 7, 2021

Uh oh!

Uh oh!

Mikhael-J commented Jul 25, 2021 •

edited

Loading