add LinkedList solution for separating odd and even nodes #4625
Conversation
ghost
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| class Node: | ||
|
|
||
| # Function to initialise the node object | ||
| def __init__(self, data): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
| self.next =None | ||
|
|
||
| # Function to segregate even and odd nodes. | ||
| def segregateEvenOdd(): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: segregateEvenOdd
Please provide return type hint for the function: segregateEvenOdd. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/linked_list/separating_odd_even_nodes.py, please provide doctest for the function segregateEvenOdd
|
|
||
| # Starting node of list having | ||
| # even values. | ||
| evenStart = None |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: evenStart
| evenStart = None | ||
|
|
||
| # Ending node of even values list. | ||
| evenEnd = None |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: evenEnd
| evenEnd = None | ||
|
|
||
| # Starting node of odd values list. | ||
| oddStart = None |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: oddStart
| else: | ||
| if(oddStart == None): | ||
| oddStart = currNode | ||
| oddEnd = oddStart |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: oddEnd
| oddEnd = oddStart | ||
| else: | ||
| oddEnd . next = currNode | ||
| oddEnd = oddEnd . next |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: oddEnd
|
|
||
| # Move head pointer one step in | ||
| # forward direction | ||
| currNode = currNode . next |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: currNode
|
|
||
| ''' UTILITY FUNCTIONS ''' | ||
| ''' Function to insert a node at the beginning ''' | ||
| def push(new_data): |
There was a problem hiding this comment.
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/linked_list/separating_odd_even_nodes.py, please provide doctest for the function push
Please provide type hint for the parameter: new_data
| head = new_node | ||
|
|
||
| ''' Function to prnodes in a given linked list ''' | ||
| def printList(): |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: printList
Please provide return type hint for the function: printList. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/linked_list/separating_odd_even_nodes.py, please provide doctest for the function printList
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.