Skip to content

/ kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log attempts to output resp.Body #104184

Open
SergeyKanzhelev opened this issue Aug 5, 2021 · 8 comments · May be fixed by #104240
Open

Log attempts to output resp.Body #104184

SergeyKanzhelev opened this issue Aug 5, 2021 · 8 comments · May be fixed by #104240
Assignees
@feeltimeQ
Labels
good first issue help wanted kind/bug needs-triage sig/cloud-provider sig/security

Comments

@SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev commented Aug 5, 2021

What happened:

Log messages like body of failing http response: &{0x531900 0xc0010d2780 0x775180} are not very informative.

/sig cloud-provider

What you expected to happen:

Either actual response body or none of it if this is a security concern.

/sig security

sig security to confirm it is ok to change this to log an actual response body.

How to reproduce it (as minimally and precisely as possible):

two places it is being logged:

Environment:

  • Kubernetes version (use kubectl version):1.20, but doesn't matter
  • Cloud provider or hardware configuration:GKE
  • OS (e.g: cat /etc/os-release):COS
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 5, 2021

@SergeyKanzhelev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@SergeyKanzhelev
Copy link
Member Author

@SergeyKanzhelev SergeyKanzhelev commented Aug 5, 2021

/help
/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 5, 2021

@SergeyKanzhelev:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Aug 6, 2021

FYI, InfoS already handle []byte display in kubernetes/klog#237, may be we can move this to structured-logging.
@feeltimeQ
Copy link

@feeltimeQ feeltimeQ commented Aug 6, 2021

/assign
skywe-tang added a commit to skywe-tang/kubernetes that referenced this issue Aug 8, 2021
@skywe-tang
fix: Log attempts to output resp.Body, part of kubernetes#104184
b0f6fd5
@skywe-tang skywe-tang mentioned this issue Aug 8, 2021
Closed
@skywe-tang
Copy link

@skywe-tang skywe-tang commented Aug 8, 2021

Hi, @feeltimeQ I just found a place to test my first submit. If you are still working on this, please let me know. I'll close my PR
@feeltimeQ
Copy link

@feeltimeQ feeltimeQ commented Aug 9, 2021

Hi, @feeltimeQ I just found a place to test my first submit. If you are still working on this, please let me know. I'll close my PR

Hi, @skywe-tang, l still working on this issues, thanks .
@skywe-tang
Copy link

@skywe-tang skywe-tang commented Aug 9, 2021

Hi, @feeltimeQ I just found a place to test my first submit. If you are still working on this, please let me know. I'll close my PR

Hi, @skywe-tang, l still working on this issues, thanks .

OK, go ahead. This PR #104225 can be used as a reference, I‘ll close it
feeltimeQ added a commit to feeltimeQ/kubernetes that referenced this issue Aug 9, 2021
@feeltimeQ
fix Log attempts to output resp.Body kubernetes#104184
5f445aa
@feeltimeQ feeltimeQ linked a pull request that will close this issue Aug 9, 2021
Open
feeltimeQ added a commit to feeltimeQ/kubernetes that referenced this issue Aug 13, 2021
@feeltimeQ
fix Log attempts to output resp.Body kubernetes#104184
9e75782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feeltimeQ feeltimeQ

Labels
good first issue help wanted kind/bug needs-triage sig/cloud-provider sig/security
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix Log attempts to output resp.Body #104184
fix: Log attempts to output resp.Body, part of #104184
5 participants
@yuzhiquan @skywe-tang @SergeyKanzhelev @k8s-ci-robot @feeltimeQ