Skip to content

/ ImageSharp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend 32bit test coverage #1386

Open
antonfirsov opened this issue Oct 15, 2020 · 2 comments
Open

Extend 32bit test coverage #1386

antonfirsov opened this issue Oct 15, 2020 · 2 comments
Labels
good first issue hacktoberfest help needed unit tests
Milestone
Future

Comments

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Oct 15, 2020 •
edited

A follow up on #1378 (comment).

Currently 32 bit test execution is only done for .NET Framework, with dotnet xunit which is an obsolete tool today, we need to adapt dotnet test, and add 32 bit CI targets for both net5.0 and netcoreapp3.1. Opening an issue to remember and track this debt.

See:
https://twitter.com/tannergooding/status/1316755685938393089
@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Oct 15, 2020

I've established that we can already use dotnet test on our Windows CI environments to run with 32bit coverage without xunit.

https://github.com/JimBobSquarePants/PlatformBuildTests/runs/1259919494

Doesn't work on Ubuntu.
@antonfirsov antonfirsov added this to the Future milestone Oct 15, 2020
@antonfirsov
Copy link
Member Author

@antonfirsov antonfirsov commented Oct 15, 2020

Windows-only coverage is already much better, than no coverage :)
@JimBobSquarePants JimBobSquarePants mentioned this issue Oct 18, 2020
Closed
4 tasks
@antonfirsov antonfirsov mentioned this issue Dec 5, 2020
Closed
4 tasks
@antonfirsov antonfirsov mentioned this issue Jun 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest help needed unit tests
Projects
None yet
Milestone
Future
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JimBobSquarePants @antonfirsov