Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #10435 update the observer dep to support a Set based implementation #12087

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

@andrew-teirney
Copy link

@andrew-teirney andrew-teirney commented May 21, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

This PR introduces a performance improvement for component destruction.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The issue that this PR aims to fix documents the observed performance issue and explains it pretty well.

At this moment in time upgrading to Vue 3 is not currently an option for me, getting some resolution to this issue would be awesome, hence the PR.

The PR aims to maintain compatibility with ES5 based browsers, but where Set is supported then it would favour that.

@andrew-teirney
Copy link
Author

@andrew-teirney andrew-teirney commented May 21, 2021

There already exists another pull request for this same issue, specifically #8157, however it appears as though that pull request never progressed.

The approach in this PR is different in its implementation in that it is Set based, which is in line with Vue 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant