Remove mplutils.cpp; shorten mplutils.h. #20873
Merged
Conversation
mplutils.cpp only provides add_dict_int, which (for us) can be replaced by PyModule_AddIntConstant (already used in the same fashion in image_wrapper.cpp). MAX and CLAMP can be replaced via std::max/std::min, as they are only used in C++ modules.
67d04a8
into
matplotlib:master
27 checks passed
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mplutils.cpp only provides add_dict_int, which (for us) can be replaced
by PyModule_AddIntConstant (already used in the same fashion in
image_wrapper.cpp).
MAX and CLAMP can be replaced via std::max/std::min, as they are only
used in C++ modules.
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).