Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearing selector #20889

Merged
merged 4 commits into from Aug 27, 2021
Merged

Conversation

@ericpre
Copy link
Member

@ericpre ericpre commented Aug 24, 2021

PR Summary

import matplotlib.pyplot as plt
from matplotlib.widgets import SpanSelector
import numpy as np

values = np.arange(0, 100)

fig = plt.figure()
ax = fig.add_subplot()
ax.plot(values, values)

selector = SpanSelector(ax, print, interactive=True)
# press escape key and move the mouse over the area where the span selector was: the mouse pointer will change
# when hovering over the edge handle even if the span selector is not visible anymore.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
@ericpre ericpre force-pushed the ericpre:fix_clearing_span_selector branch from 99b26df to 2d5ca2a Aug 25, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 25, 2021
@ericpre ericpre changed the title Fix clearing span selector Fix clearing selector Aug 25, 2021
@ericpre
Copy link
Member Author

@ericpre ericpre commented Aug 25, 2021

Sorry @timhoffm and @QuLogic, I have just thought that this actually applies to other selectors and it can be made more generic by implementing it in the base selector class, because _selection_completed is defined in the base class!

@QuLogic QuLogic requested review from QuLogic and timhoffm Aug 25, 2021
Copy link
Member

@timhoffm timhoffm left a comment

Modulo @QuLogic's comment.

@QuLogic QuLogic merged commit 944f069 into matplotlib:master Aug 27, 2021
28 checks passed
28 checks passed
@github-actions
flake8
Details
@github-actions
greeting
Details
@github-actions
Python 3.7 on ubuntu-18.04 (Minimum Versions)
Details
@github-actions
Python 3.7 on ubuntu-18.04
Details
@github-actions
Python 3.8 on ubuntu-18.04
Details
@github-actions
Python 3.9 on ubuntu-20.04
Details
@github-actions
Python 3.10-dev on ubuntu-20.04 Python 3.10-dev on ubuntu-20.04
Details
@github-actions
Python 3.8 on macos-latest
Details
@github-actions
eslint
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
@github-actions
Check the rendered docs here! Link to 0/doc/build/html/index.html
Details
@lgtm-com
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: docs-python38 Your tests passed on CircleCI!
Details
@codecov
codecov/patch 98.33% of diff hit (target 50.00%)
Details
@codecov
codecov/project/library 80.77% (target 50.00%)
Details
@codecov
codecov/project/tests 98.85% (+0.01%) compared to 8cad1b6
Details
@appveyor
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@azure-pipelines
matplotlib.matplotlib Build #20210827.8 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Check Skip) Check Skip succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Linux_py37) Main Pytest Linux_py37 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Linux_py38) Main Pytest Linux_py38 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Linux_py39) Main Pytest Linux_py39 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Windows_py37) Main Pytest Windows_py37 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Windows_py38) Main Pytest Windows_py38 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest Windows_py39) Main Pytest Windows_py39 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest macOS_py37) Main Pytest macOS_py37 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest macOS_py38) Main Pytest macOS_py38 succeeded
Details
@azure-pipelines
matplotlib.matplotlib (Main Pytest macOS_py39) Main Pytest macOS_py39 succeeded
Details
meeseeksmachine added a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 27, 2021
timhoffm added a commit that referenced this pull request Aug 28, 2021
…889-on-v3.5.x

Backport PR #20889 on branch v3.5.x (Fix clearing selector)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants