[FAB][DOCS] Floating action button ripple effect broken in demo #27973
Labels
Comments
Maybe the issue is with styling in: import * as React from 'react';
- import Box from '@material-ui/core/Box';
+ import Stack from '@material-ui/core/Stack';
import Fab from '@material-ui/core/Fab';
import AddIcon from '@material-ui/icons/Add';
export default function FloatingActionButtonSize() {
return (
- <Box
- sx={{
- '& :not(style)': { m: 1 },
- }}
- >
+ <Stack direction="row" spacing={1}>
<Fab size="small" color="secondary" aria-label="add">
<AddIcon />
</Fab>
<Fab size="medium" color="secondary" aria-label="add">
<AddIcon />
</Fab>
<Fab color="secondary" aria-label="add">
<AddIcon />
</Fab>
- </Box>
+ </Stack>
);
} |
Yes, the issue comes from the selector used on the Box, it is too wide. It should be Would you like to create a PR with the changes you proposed @rajzik? :) |
@mnajdova Sure, I will do it later today. |
1 task
@mnajdova nvm PR is now up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FAB in documentation size demo has broken ripple effect.
https://next.material-ui.com/components/floating-action-button/#size
Current Behavior😯
Demo for v5 ripple effect broken for size example
Expected Behavior🤔
Demo for v4
https://material-ui.com/components/floating-action-button/#floating-action-button
Steps to Reproduce🕹
Open chrome
https://next.material-ui.com/components/floating-action-button/#size
Steps:
Context🔦
It would great to have working example on documentation page. I saw this couple releases ago and this issue persist, so I am raising it now.
The text was updated successfully, but these errors were encountered: