Create quadratic_equation_real_and_distinct.py #4610
Conversation
an algorithm to compute the roots for a quadratic equation
ghost
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| #Computes any possible solution for a qyuadratic equation | ||
| import math | ||
|
|
||
| def quadratics_equation_solver(a: int, b: int, c: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: quadratics_equation_solver. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| #https://en.wikipedia.org/wiki/Quadratic_formula | ||
| import math | ||
|
|
||
| def quadratics_equation_solver(a: int, b: int, c: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: quadratics_equation_solver. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
| raise TypeError("value must be of type int only") | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file maths/quadratic_equation_real_and_distinct.py, please provide doctest for the function main
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Describe your change:
an algorithm to compute the roots for a quadratic equation! it takes 3 inputs and gives the number of solutions available for that equation.
Checklist: