Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename check_valid_ip_address.py to is_ip_v4_address_valid.py #4665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update and rename check_valid_ip_address.py to is_ip_v4_address_valid.py #4665

wants to merge 2 commits into from
+51 −47

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Aug 24, 2021 •
edited

The names of functions that return a boolean should start with is_

IP v6 addresses have a different syntax than IP v4 addresses.

New test cases that the algorithm must detect:

  • an octet much bigger than 255
  • an octet is negative
  • number of octets is less than 4
  • number of octets is greater than 4
  • an octet is a letter

@shubhamsg199 your review, please.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Aug 24, 2021
@cclauss
Update and rename check_valid_ip_address.py to is_ip_v4_address_valid.py
799fd61 
New test cases that the algorithm must detect:
* [ ] an octet much bigger than 255
* [ ] an octet is negative
* [ ] number of octets is less than 4
* [ ] number of octets is greater than 4
* [ ] an octet is a letter
github-actions github-actions
updating DIRECTORY.md
e0bb2f1
@cclauss cclauss requested a review from Kush1101 as a code owner Aug 24, 2021
@shubhamsg199
shubhamsg199 approved these changes Aug 24, 2021
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199

@Kush1101 Kush1101

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @shubhamsg199