bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only #28002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyPy and potentially other implementations have different or no contraints on the number of blocks that can be statically nested. move the test that checks for this behaviour into a unit test and mark it as CPython-only.
serhiy-storchaka
changed the title
serhiy-storchaka
added
needs backport to 3.9
serhiy-storchaka
approved these changes
Aug 28, 2021
|
Thanks @cfbolz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @cfbolz and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-28016 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 28, 2021
…ted blocks cpython-only (pythonGH-28002) PyPy and potentially other implementations have different or no contraints on the number of blocks that can be statically nested. move the test that checks for this behaviour into a unit test and mark it as CPython-only. (cherry picked from commit eb263f9) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
serhiy-storchaka
added
needs backport to 3.9
|
Thanks @cfbolz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry @cfbolz and @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 28, 2021
…of nested blocks cpython-only (pythonGH-28002) PyPy and potentially other implementations have different or no contraints on the number of blocks that can be statically nested. move the test that checks for this behaviour into a unit test and mark it as CPython-only.. (cherry picked from commit eb263f9) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
|
GH-28017 is a backport of this pull request to the 3.9 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 28, 2021
…ted blocks cpython-only (GH-28002) (GH-28016) PyPy and potentially other implementations have different or no contraints on the number of blocks that can be statically nested. move the test that checks for this behaviour into a unit test and mark it as CPython-only. (cherry picked from commit eb263f9) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 28, 2021
…of nested blocks cpython-only (GH-28002) (GH-28017) PyPy and potentially other implementations have different or no contraints on the number of blocks that can be statically nested. move the test that checks for this behaviour into a unit test and mark it as CPython-only.. (cherry picked from commit eb263f9) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
mozillazg
pushed a commit
to mozillazg/pypy
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyPy and potentially other implementations have different or no
constraints on the number of blocks that can be statically nested. move
the doctest that checks for this behaviour into a unit test and mark it as
CPython-only.
In PyPy, the doctest happily looped forever, because there is no syntax error raised 😞
https://bugs.python.org/issue25130