Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] Fail the CI if an optional module fails to compile (GH-27466). #27481

Merged
merged 1 commit into from Jul 30, 2021
Merged

[3.10] Fail the CI if an optional module fails to compile (GH-27466). #27481

merged 1 commit into from Jul 30, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 30, 2021

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com

@ambv
Copy link
Contributor

@ambv ambv commented Jul 30, 2021

The macOS failure demonstrates the value of this check:

Failed to build these modules:
_tkinter

@ambv
Copy link
Contributor

@ambv ambv commented Jul 30, 2021

The root cause is:

 In file included from /Users/runner/work/cpython/cpython/Modules/_tkinter.c:46:
/usr/local/include/tk.h:96:13: fatal error: 'X11/Xlib.h' file not found
#   include <X11/Xlib.h>
            ^~~~~~~~~~~~

@pablogsal
[3.10] Fail the CI if an optional module fails to compile (pythonGH-2…
38ec767 
…7466).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jul 30, 2021

Seems that the problem is that the configure version was too new (!)

@pablogsal pablogsal merged commit c2e0b13 into python:3.10 Jul 30, 2021
13 of 14 checks passed
@pablogsal pablogsal deleted the backport-7cad0be-3.10 branch Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @ambv @the-knights-who-say-ni @bedevere-bot