bpo-42990: Further refactoring of PyEval_ functions. #24368
Merged
Conversation
…rame, and eval-frame parts.
…ore like other vector calls.
|
(Isn't news also used to alert developers of structural changes to the interpreter?) |
|
There's no API changes, so I assumed not. |
markshannon
merged commit 0332e56
into
python:master
11 checks passed
11 checks passed
bedevere/news
News entry found in Misc/NEWS.d
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Feb 8, 2021
* Further refactoring of PyEval_EvalCode and friends. Break into make-frame, and eval-frame parts. * Simplify function vector call using new _PyEval_Vector. * Remove unused internal functions: _PyEval_EvalCodeWithName and _PyEval_EvalCode. * Don't use legacy function PyEval_EvalCodeEx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Removes a further layer of indirection for calling Python functions, by replacing
_PyEval_EvalCodeWithName()which took a large an incoherent set of parameters with_PyEval_Vector()which takes fewer than half the parameters, and is more efficient in the common case of calling a function.Skipping NEWS as this should have no visible effect on API or performance, nor does it fix any bugs. It just makes our life easier in the future.
https://bugs.python.org/issue42990