Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: limit-conn plugin in stream proxy #4933

Open
tokers opened this issue Aug 30, 2021 · 6 comments
Open

docs: limit-conn plugin in stream proxy #4933

tokers opened this issue Aug 30, 2021 · 6 comments
Labels
doc good first issue

Comments

@tokers
Copy link
Contributor

@tokers tokers commented Aug 30, 2021

Improved or typo fixed.

Currently, the limit-conn is supported in the stream proxy, but the documentation about limit-conn doesn't give a good example to show how to use it in stream proxy.

Documentation link: http://apisix.apache.org/docs/apisix/plugins/limit-conn.

Solution

We may add an example for how to use limit-conn in the stream proxy.
@Ayushsunny
Copy link

@Ayushsunny Ayushsunny commented Sep 28, 2021

Hi @tokers

I would like to work on it, could you guide me to approach this issue?

@tokers
Copy link
Contributor Author

@tokers tokers commented Sep 28, 2021

@Ayushsunny I just checked it out and I found it was supported.

@tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Sep 28, 2021

@tokers where? we can show links and close this issue.

@tokers
Copy link
Contributor Author

@tokers tokers commented Sep 29, 2021

https://github.com/apache/apisix/blob/master/apisix/stream/plugins/limit-conn.lua

@tzssangglass
Copy link
Member

@tzssangglass tzssangglass commented Sep 29, 2021

I mean doc not code about stream plugin

@tokers
Copy link
Contributor Author

@tokers tokers commented Sep 30, 2021

http://apisix.apache.org/docs/apisix/plugins/limit-conn,

We don't have a separate doc but have some mentions in the above one.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@tokers @tzssangglass @Ayushsunny