Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove unnecessary polyfills from tests #42567

Closed
wants to merge 1 commit into from
Closed

build: remove unnecessary polyfills from tests #42567

wants to merge 1 commit into from

Conversation

Reviewers

@devversion devversion

@gkalpak gkalpak

Assignees
No one assigned
Labels
action: merge cla: yes comp: build & ci target: patch
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@crisbeto @devversion @gkalpak
@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 13, 2021 •
edited
Loading

Removes the polyfills for MutationObserver and setPrototypeOf from our testing setup, because none of the browsers that we support require them. This results in slightly less code and the removal of an external dependency.
@google-cla google-cla bot added the cla: yes label Jun 13, 2021
@ngbot ngbot bot added this to the Backlog milestone Jun 13, 2021
@ngbot ngbot bot added this to the Backlog milestone Jun 13, 2021
@ngbot ngbot bot added this to the Backlog milestone Jun 13, 2021
@crisbeto
build: remove unnecessary polyfills from tests
0faf8d7 
Removes the polyfills for `MutationObserver` and `setPrototypeOf` from our testing setup, because none of the browsers that we support require them. It also removes a bit of code and one external dependency.
@crisbeto crisbeto force-pushed the unnecessary-test-polyfills branch from 0d7fe2f to 0faf8d7 Jun 13, 2021
@crisbeto crisbeto marked this pull request as ready for review Jun 13, 2021
@pullapprove pullapprove bot requested a review from gkalpak Jun 13, 2021
alxhub added a commit that referenced this issue Jun 14, 2021
@crisbeto @alxhub
build: remove unnecessary polyfills from tests (#42567)
b362344 
Removes the polyfills for `MutationObserver` and `setPrototypeOf` from our testing setup, because none of the browsers that we support require them. It also removes a bit of code and one external dependency.

PR Close #42567
@alxhub alxhub closed this in a66dd88 Jun 14, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jul 15, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Loading

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.