CLN: Minor cleanup of deprecations in parser code #43372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Sep 2, 2021
jbrockmendel
reviewed
Sep 3, 2021
| @@ -442,7 +440,6 @@ | |||
| } | |||
|
|
|||
| _deprecated_defaults: dict[str, Any] = {"error_bad_lines": None, "warn_bad_lines": None} | |||
| _deprecated_args: set[str] = {"error_bad_lines", "warn_bad_lines"} | |||
There was a problem hiding this comment.
looks like both of these are present in the parsers.pyi file but not in parsers.pyx. Does one of those need to be updated?
lithomas1
force-pushed
the
cln-deprecations
branch
from
69b2197 to
3f4f90e
Compare
|
thanks @lithomas1 |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some spaghetti that I noticed and was annoying.