Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux, Windows, Firefox support for browser-info #822

Open
corevo opened this issue Sep 20, 2019 · 3 comments
Open

Add Linux, Windows, Firefox support for browser-info #822

corevo opened this issue Sep 20, 2019 · 3 comments

Comments

@corevo
Copy link
Member

@corevo corevo commented Sep 20, 2019

  • Linux
  • Windows
  • Firefox

Linux is pretty similar and even easier than macOS, there is a google-chrome binary in PATH and it can be parsed to any of the channels. (google-chrome --version)

@corevo corevo created this issue from a note in Selenium IDE 4 (To do) Sep 20, 2019
@corevo
Copy link
Member Author

@corevo corevo commented Sep 20, 2019

This chromedriver code can help with finding the location of Chrome binaries in the system.

@dkindt
Copy link

@dkindt dkindt commented Aug 8, 2020

I would like to pick this up. I have been reviewing code and it looks like you've added Linux support. Can we update this issue? It seems as tho there's just Windows and Firefox support left?

@corevo
Copy link
Member Author

@corevo corevo commented Aug 10, 2020

Yes I added Linux support because I just tested it on Docker, my original plan was to add github actions and test it on all systems (just these tests that depend on OS fs structure).

So the Windows task is a bit rough, I was lazy for no reason just because I use mac, but I should've setup github actions correctly, feel free to add Firefox, it should be similar, and if you want we can create an issue regarding CI, and what runs on what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Selenium IDE 4
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants