dockerfiles: pin jedi to allow ipython tab completion #50754
Merged
+24
−14
Conversation
Tab completion doesn't work on Jupyter because of an incompatibility issue. Using the web notebook, only an obscure error is printed to console but in the case of ipython console, the whole REPL crashes. This works around the issue by pinning the jedi library to the last compatible version. See: ipython/ipython#12740 Signed-off-by: japm48 <japm48gh@gmail.com>
|
@angerson Can you please review this PR ? Thanks! |
copybara-service
bot
merged commit 022db15
into
tensorflow:master
12 of 15 checks passed
12 of 15 checks passed
cla/google
All necessary CLAs are signed
feedback/copybara
Google internal checks PASS for runs with create time 2021-09-03T12:44:10.705517627Z.
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Tab completion doesn't work on Jupyter because of an incompatibility
issue. Using the web notebook, only an obscure error is printed to console
but in the case of ipython console, the whole REPL crashes.
This works around the issue by pinning the jedi library to the last
compatible version.
See: ipython/ipython#12740