Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for asyncio.open_connection() #144

Merged
merged 5 commits into from Jan 21, 2021
Merged

Conversation

fvigo
Copy link
Contributor

@fvigo fvigo commented Jan 19, 2021

Fixes an issue where asyncio.open_connection() hangs in a replay use case (i.e. when you want to record/replay data). Since send() and not sendall() is not called directly by asyncio, a proper check must be added.

Note that the use case still generates some issues in SSL sessions.

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2021

Coverage Status

Coverage remained the same at 98.705% when pulling abeab44 on fvigo:asyncio_send into 455513b on mindflayer:master.

@mindflayer mindflayer merged commit 8552563 into mindflayer:master Jan 21, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants