Skip to content

/ C-Sharp-Algorithms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsAnagram logic needs to be fixed #11

Open
harsh-athalye opened this issue Aug 20, 2015 · 1 comment
Open

IsAnagram logic needs to be fixed #11

harsh-athalye opened this issue Aug 20, 2015 · 1 comment
Assignees
@aalhour
Labels
bug good first issue
Projects
Kanban Board

Comments

@harsh-athalye
Copy link

@harsh-athalye harsh-athalye commented Aug 20, 2015

I think the IsAnagram() method doesn't work as expected. For example, it would fail for the below string combinations ("abc","bbb") or ("acdf", "bcde").

I think a simple LINQ implementation would be easy enough to implement here.
If you like, I could do that and also implement unit tests for it.
@aalhour
Copy link
Owner

@aalhour aalhour commented Aug 20, 2015

Hi, thanks for your comment. I am well aware of that issue but haven't pushed the new fixes yet. I would like to know your comment regarding the new changes when I push them, so please do keep checking it.

On a side note, I think it would be more meaningful (from an educational standpoint) to have an algorithmic implementation that doesn't depend on LINQ, since you don't exactly know what happens under the hood. :)
@aalhour aalhour closed this Aug 20, 2015
@aalhour aalhour self-assigned this Nov 1, 2019
@aalhour aalhour added this to To do in Kanban Board via automation Nov 1, 2019
@aalhour aalhour reopened this Nov 1, 2019
Kanban Board automation moved this from To do to In progress Nov 1, 2019
itai192 referenced this issue Sep 25, 2020
@itai192
changed isAnagram algorythm to other logic
63b2fa3 
this is my first commit to a public repo, so i don't know if i'm doing it right
@itai192 itai192 mentioned this issue Sep 25, 2020
Open
7 of 8 tasks
@ZacharyPatten ZacharyPatten mentioned this issue Jan 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalhour aalhour

Labels
bug good first issue
Projects
Kanban Board
  
In progress
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@aalhour @harsh-athalye