CPP: Add query for CWE-675: Duplicate Operations on Resource #6588
+268
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Sep 3, 2021
This looks like a useful query, but the code is a little difficult to understand at the moment.
cpp/ql/src/experimental/Security/CWE/CWE-675/DoubleRelease.qhelp
Outdated
Show resolved
Hide resolved
|
|
||
| /** Holds if the first arguments of the two functions are similar. */ | ||
| predicate similarArguments(FunctionCall fc, FunctionCall fc1) { | ||
| globalValueNumber(fc.getArgument(0)) = globalValueNumber(fc1.getArgument(0)) |
There was a problem hiding this comment.
This simple case looks good to me. How often do the other two cases (below) help?
There was a problem hiding this comment.
all situations were detected on my tests. I would like to leave these cases, also because they provide cve detection.
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
1 task
|
Results look good to me. There may well be a performance issue with this query, but in my opinion we don't need to worry about that before merging into experimental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
double release of descriptors can lead to an abnormal program termination.
when making a request to double free memory, I skipped the specified impact vector.
however, the situation described in CVE-2019-13351 suggests the need for such a request.
actual PR
bloomberg/comdb2#2940