TheAlgorithms / C-Plus-Plus

Sponsor

Sponsor TheAlgorithms/C-Plus-Plus
Notifications
Star 15.2k
Fork 4.1k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create swap.cpp #1591

Open

helper-uttam wants to merge 4 commits into TheAlgorithms:master from helper-uttam:patch-2

+75 −0

helper-uttam commented Sep 5, 2021 •

edited by gitpod-io bot

This program uses XOR bitwise and swap the values of 2 variables

Description of Change

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:
This program uses XOR bitwise and swap 2 values.


          Create swap.cpp

66b9524

This program uses XOR bitwise and swap the values of 2 variables

mishraabhinn added awaiting modification enhancement good first issue labels

mishraabhinn requested changes

Member

mishraabhinn left a comment

@helper-uttam Proper Documentation and formatting needed. You can also have a look for previous successfully pr merged for reference. Thanks.
Refer


          Update swap.cpp

c6501de

Author

helper-uttam commented Sep 5, 2021

@helper-uttam Proper Documentation and formatting needed. You can also have a look for previous successfully pr merged for reference. Thanks.
Refer

I had added documentation related with every line of code. Now if there anything left please let me know?

mishraabhinn requested changes

bit_manipulation/swap.cpp Outdated Show resolved Hide resolved

Panquesito7 requested changes

Member

Panquesito7 left a comment

Hey there! Thank you for submitting a PR! 😄 Sadly, this does not meet our requirements. Check out our repository standards. Please read them carefully and follow them. Also, check comments by @mishraabhinn. 🙂

Panquesito7 added automated tests are failing Proper Documentation Required requested changes labels


          Update swap.cpp

025d0ce

not working

Author

helper-uttam commented Sep 6, 2021

can someone please suggest me some changes. Like assert(bit_manipulation::swap::swap_XOR(11, 2) == (2,11)); this require swap_XOR to return 2values but Is it possible to return two values from a function?

Member

mishraabhinn commented Sep 6, 2021 •

edited

can someone please suggest me some changes. Like assert(bit_manipulation::swap::swap_XOR(11, 2) == (2,11)); this require swap_XOR to return 2values but Is it possible to return two values from a function?

Pass reference in the swap function instead of pointer and compare individual values using assert.


          Update swap.cpp

324272f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment