Skip to content

Make asyncio main importable by fixing references to global vars #28184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make asyncio main importable by fixing references to global vars #28184

wants to merge 1 commit into from

Conversation

asrp
Copy link

@asrp asrp commented Sep 6, 2021

RIght now, importing this module makes classes in it unusable as the name == '__main__' block isn't run. This is a small fix for that.

The change is small but please let me know if this is issue number worthy.

@asrp asrp requested review from 1st1 and asvetlov as code owners September 6, 2021 16:39
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@asrp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@nanjekyejoannah nanjekyejoannah changed the title (No issue number) Make asyncio main importable by fixing references to global vars Make asyncio main importable by fixing references to global vars Sep 6, 2021
@serhiy-storchaka
Copy link
Member

You should not import from ayncio.__main__, it is not designed for importing.

If you have a use case please open an issue on the bug tracker for discussion. Only trivial PRs do not require corresponding issue.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asrp @the-knights-who-say-ni @serhiy-storchaka @bedevere-bot @nanjekyejoannah