Skip to content

bpo-37529: delete duplicate mimetype for bmp files #28244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Sep 8, 2021

This is in effect a backport of #26300 to 3.9 .

I'm not sure I'm doing this right, this is the first time I'm doing a backport. (but the change is one deleted line so it's probably the easiest way?)

Not adding news entry because #26300 didn't have one.

https://bugs.python.org/issue37529

@Fidget-Spinner
Copy link
Member

There's a guide to backports and the correct format here: https://devguide.python.org/gitbootcamp/#backporting-merged-changes.

Also one part it doesn't mention, please prepend the target branch version in your PR title. So in this case it's [3.9] bpo-xxx Remove duplicate mime type mapping .bmp -> image/x-ms-bmp.

Otherwise, this all looks good to me. Thanks.

@serhiy-storchaka
Copy link
Member

#26300 was not backported. Instead of creating a separate PR manually we just add labels "backport to X.Y".

@serhiy-storchaka serhiy-storchaka added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error and removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Sep 11, 2021
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Sep 17, 2021

Andrei doesn't have permissions to add labels yet. So I'll add it for him.

Edit: Nevermind woops, it seems that Serhiy has already set the label. Thank you Serhiy :).

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Sep 17, 2021

It seems that we're not going to backport this since it's a potentially backwards incompatible change in a minor version update. Please see https://bugs.python.org/issue22589 for the discussion @akulakov on something similar in the past . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants