bpo-31062: Allow socket.makefile to handle line buffering properly #12370

vxgmichel · 2019-03-16T17:20:23Z

Line buffering is enabled by using the argument buffering=1 as defined in io.open.

I did not update the docs for socket.makefile since it already mentions the arguments being interpreted the same way as open:

Return a file object associated with the socket. The exact returned type depends on the arguments given to makefile(). These arguments are interpreted the same way as by the built-in open() function, except the only supported mode values are 'r' (default), 'w' and 'b'.

https://bugs.python.org/issue31062

Lib/socket.py

Lib/test/test_socket.py

Misc/NEWS.d/next/Library/2019-03-16-17-59-18.bpo-31062.8vxQyS.rst

Line buffering is enabled by using the argument `buffering=1` as defined in `io.open`.

the-knights-who-say-ni added the CLA signed label Mar 16, 2019

bedevere-bot added the awaiting review label Mar 16, 2019

ZackerySpytz reviewed Apr 22, 2019

View changes

vxgmichel force-pushed the bpo-31062 branch from 92d3b7b to 030c991 Compare Apr 22, 2019

bpo-31062: Allow socket.makefile to handle line buffering properly

2eaecd5

Line buffering is enabled by using the argument `buffering=1` as defined in `io.open`.

vxgmichel force-pushed the bpo-31062 branch from 030c991 to 2eaecd5 Compare Sep 9, 2021

ezio-melotti removed the CLA signed label Jul 13, 2022

bpo-31062: Allow socket.makefile to handle line buffering properly #12370

Are you sure you want to change the base?

bpo-31062: Allow socket.makefile to handle line buffering properly #12370

Conversation

vxgmichel commented Mar 16, 2019 • edited by bedevere-bot

vxgmichel commented Mar 16, 2019 •

edited by bedevere-bot