Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44959: Added fallback to extension modules with '.sl' suffix on HP-UX #27857

Merged
merged 4 commits into from Sep 8, 2021
Merged

bpo-44959: Added fallback to extension modules with '.sl' suffix on HP-UX #27857

merged 4 commits into from Sep 8, 2021

Conversation

@florinspatar
Copy link
Contributor

@florinspatar florinspatar commented Aug 20, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44959
Added fallback to extension modules with '.sl' suffix on HP-UX
d4d928e
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Aug 20, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@florinspatar

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@blurb-it
📜🤖 Added by blurb_it.
a7ff785
@vstinner vstinner closed this Sep 7, 2021
@vstinner vstinner reopened this Sep 7, 2021
@vstinner
Copy link
Member

@vstinner vstinner commented Sep 7, 2021

I closed/reopened the PR to re-run the failed CI job: Address sanitizer (pull_request):

2 tests failed: test__xxsubinterpreters test_multiprocessing_fork

Please ping me once tests pass, I will merge your PR ;-)

vstinner
vstinner approved these changes Sep 7, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

The NEWS entry should be in the "Core" category, but I don't care much. Change it it you want (remove the old file, re-run blurb to add a new entry).

florinspatar and others added 2 commits Sep 8, 2021
@florinspatar
Delete 2021-09-03-10-47-22.bpo-44959.OSwwPf.rst
1d68d6c 
The NEWS entry should be in the "Core" category
@blurb-it
📜🤖 Added by blurb_it.
8f2cea5
@florinspatar
Copy link
Contributor Author

@florinspatar florinspatar commented Sep 8, 2021

Did the requested NEWS change. test_multiprocessing_fork seem to fail randomly

@vstinner vstinner merged commit 2396fa6 into python:main Sep 8, 2021
12 checks passed
@vstinner
Copy link
Member

@vstinner vstinner commented Sep 8, 2021

Merged, thanks for your contribution @florinspatar!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 22, 2021

Thanks @florinspatar for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 22, 2021

Thanks @florinspatar for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 22, 2021

GH-29152 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 22, 2021

GH-29153 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Oct 22, 2021
@florinspatar @miss-islington
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
1bda9dc 
…UX (pythonGH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
miss-islington added a commit to miss-islington/cpython that referenced this issue Oct 22, 2021
@florinspatar @miss-islington
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
4c1bec3 
…UX (pythonGH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
miss-islington added a commit that referenced this issue Oct 22, 2021
@florinspatar @miss-islington
bpo-44959: Add fallback to extension modules with '.sl' suffix on HP-…
aa8c344 
…UX (GH-27857)

(cherry picked from commit 2396fa6)

Co-authored-by: Florin Spătar <florin.spatar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@florinspatar @the-knights-who-say-ni @vstinner @miss-islington @bedevere-bot