New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45107: Make LOAD_METHOD_CLASS safer and faster, clean up comments #28177
bpo-45107: Make LOAD_METHOD_CLASS safer and faster, clean up comments #28177
Conversation
I'll ping Mark when he's back. IIUC, |
If you want to schedule another build, you need to add the " |
@erlend-aasland the more I look at this the more iffy my code feels. I'm trying to think if this could cause any segfaults. E.g. it accesses a non-type object at Previously the dict check also served as an object identity check since This is guaranteed to always work though if all objects are bigger than |
I do not, and unfortunately I do not have any time to investigate now :( |
Thanks for the review Erlend, ultimately I decided to roll back the changes and make the checks stricter. My tests indicate we lost |
Looks good, thanks. |
FWIW, I can't repro the windows build errors locally. It seems to be affecting every PR right now. |
Thanks Mark and Erlend for the reviews! |
https://bugs.python.org/issue45107