[skip issue] [skip news] Update libffi dll name to libffi-8 #28203
+1
−1
Conversation
giovanniwijaya
changed the title
|
Thanks for this! Oversight on my part. |
zooba
merged commit 4dc4300
into
python:main
14 checks passed
14 checks passed
![@github-actions[bot]](https://web.archive.org/web/20210910034120im_/https://avatars.githubusercontent.com/in/15368?v=4){kind=small}
bedevere/issue-number
Issue report skipped
bedevere/news
"skip news" label found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In Tools/msi/lib/lib_files.wxs, the libffi dll name was still kept as libffi-7.dll, corresponding to version 3.3.0. As GH-28146 updates libffi version to 3.4.2 (and the dll name to libffi-8.dll), this causes failure when building the Windows installer.
The text was updated successfully, but these errors were encountered: