Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44854: Add .editorconfig file to help enforce
make patchcheck
#27638bpo-44854: Add .editorconfig file to help enforce
make patchcheck
#27638Changes from all commits
4152538
398a62a
File filter
Conversations
Jump to
There are no files selected for viewing
serhiy-storchakaAug 9, 2021
Member
Note that there are currently many imported or generated files with trailing spaces: files for building on Windows and macOS (
*.wixproj
,*.wxs
,*.icns
,*.nib
, etc), test data files (for xml, email, etc), sources of third-party libraries (libffi, blake2), etc.Try to run
and then
to get a list of files containing trailing spaces.
ambvAug 9, 2021
Author
Contributor
In this case I can move this directive to only address
.py
,.c
,.h
,.rst
,.md
,.yml
. What do you think?ambvAug 9, 2021
Author
Contributor
By the way, shouldn't
make patchcheck
complain about this trailing whitespace?ambvAug 9, 2021
Author
Contributor
Running the suggested
sed
and then aggregating data by file extension it looks like this:So yeah, I do think that limiting whitespace trimming to the extensions I highlighted above will do the job.
serhiy-storchakaAug 9, 2021
Member
LGTM. And maybe exclude some directories like
Modules/_blake2/impl/
,Modules/_ctypes/libffi_osx/
, etc? I am not sure what is the status of these files and how they are supposed to be synchronized with upstream.As for patcheck, it is just not used for C files.