Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44340: Add support for building with clang full/thin lto #27231
bpo-44340: Add support for building with clang full/thin lto #27231
Changes from all commits
e5fd3b8
ce0757f
5668510
814b241
1d3f6fa
File filter
Conversations
Jump to
There are no files selected for viewing
corona10Jul 18, 2021
Author
Member
If the Py_LTO_POLICY is the default, it will follow the default LTO option of compiler
corona10Jul 18, 2021
•
edited
Author
Member
@holmanb
Should we check the full option also?
IMHO,
-flto
itself can be the alternative to thefull
option.holmanbJul 18, 2021
I don't have strong opinions on this. Assuming
-flto
whenfull
is passed as an option is a sensible assumption, sincefull
is the default lto policy on clang, and no other compilers that I'm aware of have multiple lto implementations.It may lead to confusion in the future if, for example, clang changes default --flto policy to be thin, or if other compilers produce alternative lto implementations that have different naming schemes. That said, unless anyone else has stronger opinions, I'd say leave it as is.
gpsheadJul 18, 2021
Member
agreed.