Skip to content

/ pandas

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD: make tests discoverable in .devcontainer.json #34929

Merged
merged 2 commits into from Jun 23, 2020
Merged

BUILD: make tests discoverable in .devcontainer.json #34929

merged 2 commits into from Jun 23, 2020
+3 −1

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jun 22, 2020 •
edited

I wasn't able to discover tests using the current setup, I had to use "python.testing.pytestArgs" instead of "python.testing.cwd"
@MarcoGorelli
remove pytest.testing.cwd as that's already in setup.cfg
962953b
@MarcoGorelli MarcoGorelli marked this pull request as draft Jun 22, 2020
@MarcoGorelli
use pytestArgs instead
5923751
@MarcoGorelli MarcoGorelli marked this pull request as ready for review Jun 22, 2020
@WillAyd
WillAyd approved these changes Jun 22, 2020
View changes
Copy link
Member

@WillAyd WillAyd left a comment

lgtm
@WillAyd WillAyd added the Build label Jun 22, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jun 22, 2020
@WillAyd WillAyd merged commit d8c2ab5 into pandas-dev:master Jun 23, 2020
14 checks passed
14 checks passed
@github-actions
Checks
Details
@github-actions
Web and docs
Details
@codecov
codecov/patch Coverage not affected when comparing 8ba9c62...5923751
Details
@codecov
codecov/project 93.94% (target 82.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@azure-pipelines
pandas-dev.pandas Build #20200622.11 succeeded
Details
@azure-pipelines
pandas-dev.pandas (Linux py36_locale) Linux py36_locale succeeded
Details
@azure-pipelines
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
@azure-pipelines
pandas-dev.pandas (Linux py36_minimum_versions) Linux py36_minimum_versions succeeded
Details
@azure-pipelines
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
@azure-pipelines
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
@azure-pipelines
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
@azure-pipelines
pandas-dev.pandas (Windows py37_np18) Windows py37_np18 succeeded
Details
@azure-pipelines
pandas-dev.pandas (macOS py36_macos) macOS py36_macos succeeded
Details
@WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 23, 2020

Thanks @MarcoGorelli

@MarcoGorelli MarcoGorelli deleted the MarcoGorelli:make-tests-discoverable branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
1.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@MarcoGorelli @WillAyd