Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44340: Add support for building with clang full/thin lto #27231

Merged
merged 5 commits into from Jul 19, 2021
Merged

bpo-44340: Add support for building with clang full/thin lto #27231

merged 5 commits into from Jul 19, 2021

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jul 18, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44340
@corona10 corona10 requested review from ned-deily and pablogsal Jul 18, 2021
@corona10 corona10 changed the title bpo-44340: Add support for building with clang full/thin lto [DRAFT] bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 18, 2021

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities (https://bugs.python.org/issue44035)

@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 18, 2021

Make sure you use @tiran solution for regenerating autoconf or otherwise is going to cause some incompatibilities

Thanks, I will check it out

@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 18, 2021

@pablogsal cc @tiran
Okay, it perfectly works :)

@corona10 corona10 mentioned this pull request Jul 18, 2021
Closed
@corona10
corona10 reviewed Jul 18, 2021
View changes
configure.ac
;;
yes)
Py_LTO='true'
Py_LTO_POLICY='default'

This comment has been minimized.

Sign in to view
@corona10

corona10 Jul 18, 2021
Author Member

If the Py_LTO_POLICY is the default, it will follow the default LTO option of compiler
@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 18, 2021

cc @holmanb

@corona10
corona10 reviewed Jul 18, 2021
View changes
configure.ac Show resolved Hide resolved
@gpshead
gpshead approved these changes Jul 18, 2021
View changes
@corona10 corona10 requested review from gvanrossum and markshannon as code owners Jul 18, 2021
@gpshead
Copy link
Member

@gpshead gpshead commented Jul 18, 2021

I believe you pushed a bunch of unrelated commits to the branch.

corona10 added 5 commits Jul 18, 2021
@corona10
bpo-44340: Add support for building with clang full/thin lto
e5fd3b8
@corona10
bpo-44340: Use @tiran solution
ce0757f
@corona10
bpo-44340: Update
5668510
@corona10
bpo-44340: Fix
814b241
@corona10
bpo-44340: Update Doc
1d3f6fa
@corona10 corona10 force-pushed the corona10:bpo-44340 branch from fd45916 to 1d3f6fa Jul 18, 2021
@corona10 corona10 removed request for gvanrossum and markshannon Jul 18, 2021
@corona10 corona10 changed the title [DRAFT] bpo-44340: Add support for building with clang full/thin lto bpo-44340: Add support for building with clang full/thin lto Jul 18, 2021
@corona10
Copy link
Member Author

@corona10 corona10 commented Jul 18, 2021

I believe you pushed a bunch of unrelated commits to the branch.

Thanks, I make a lot of people noise ;)
I've rebased the PR.

@corona10
corona10 reviewed Jul 19, 2021
View changes
Copy link
Member Author

@corona10 corona10 left a comment

I am now waiting for @pablogsal 's review who is the release manager of Python 3.11 :)
@pablogsal
pablogsal approved these changes Jul 19, 2021
View changes
Copy link
Member

@pablogsal pablogsal left a comment

Great job @corona10 and @holmanb !
@corona10 corona10 merged commit b2cf251 into python:main Jul 19, 2021
13 checks passed
13 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210718.48 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44340 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@corona10 corona10 deleted the corona10:bpo-44340 branch Jul 19, 2021
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
3104b61 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
c7f03cb 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
de33627 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jul 20, 2021
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889 
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this pull request Aug 12, 2021
@corona10 @JuniorJPDJ
bpo-44340: Add support for building with clang full/thin lto (pythonG…
1ef1370 
…H-27231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb

@gpshead gpshead

@pablogsal pablogsal

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@corona10 @pablogsal @gpshead @holmanb @the-knights-who-say-ni @bedevere-bot