Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44997: macOS does not support loadable SQLite extensions #27979

Merged
merged 1 commit into from Aug 27, 2021
Merged

bpo-44997: macOS does not support loadable SQLite extensions #27979

merged 1 commit into from Aug 27, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 26, 2021 •
edited by bedevere-bot

Authored-by: Ronald Oussoren ronaldoussoren@mac.com

https://bugs.python.org/issue44997
@erlend-aasland
bpo-44997: macOS does not support loadable SQLite extensions
879fc7f 
Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 26, 2021 •
edited

I applied skip news for this. Scream out if you disagree, @ronaldoussoren.

Also, I'd say backport to 3.10, maybe even 3.9. Let me know if you agree.

@ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Aug 26, 2021

Skipnews should be fine.

Is the error message clear enough? I don't think it is necessary to mention the configure flag here because you have to explicitly opt in to loadable extensions to get this error.

ronaldoussoren
ronaldoussoren approved these changes Aug 26, 2021
View changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

LGTM

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 26, 2021

Is the error message clear enough? I don't think it is necessary to mention the configure flag here because you have to explicitly opt in to loadable extensions to get this error.

Yes, I agree.

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 26, 2021

Do you agree that we should backport this?

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 26, 2021

cc. @pablogsal regarding backporting, as he is the release manager.

@ambv
Copy link
Contributor

@ambv ambv commented Aug 27, 2021

I want this in 3.9 so it has to go to 3.10 too. Pablo can decide if it fits for 3.10.0rc2 or 3.10.1.

ambv pushed a commit that referenced this issue Aug 27, 2021
@erlend-aasland
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)
2ec9428 
Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@ambv ambv merged commit 2ec9428 into python:main Aug 27, 2021
11 checks passed
11 checks passed
@github-actions[bot]
Check for source changes
Details
@github-actions[bot]
Check if generated files are up to date
Details
@github-actions[bot]
Windows (x86)
Details
@github-actions[bot]
Windows (x64)
Details
@github-actions[bot]
macOS
Details
@github-actions[bot]
Ubuntu
Details
@github-actions[bot]
Ubuntu SSL tests with OpenSSL
Details
@github-actions[bot]
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210826.56 succeeded
Details
@bedevere-bot
bedevere/issue-number Issue number 44997 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 27, 2021

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 27, 2021
@erlend-aasland @miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (pythonG…
644a954 
…H-27979)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 27, 2021

GH-27994 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 27, 2021
@erlend-aasland @miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (pythonG…
a329671 
…H-27979)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 27, 2021

GH-27995 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 27, 2021

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 27, 2021

GH-27996 is a backport of this pull request to the 3.8 branch.

@erlend-aasland erlend-aasland deleted the sqlite-no-extensions-for-you branch Aug 27, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 27, 2021

Thanks, @ambv! I'm sorry, I should've CC'd you as well regarding backports.

ambv pushed a commit that referenced this issue Aug 27, 2021
@erlend-aasland @miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)…
9c74678 
… (GH-27996)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this issue Aug 27, 2021
@erlend-aasland @miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)
baa8d48 
Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this issue Aug 27, 2021
@erlend-aasland @miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)…
9500dd5 
… (GH-27995)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@erlend-aasland @ronaldoussoren @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni