chore(typescript): turn on noImplicitOverride #7810
Merged
Conversation
What's the reason for this one? Also, why does it update all our deps? |
Sorry I should've marked it as a draft because it depended on the the typescript roll. It should look a lot cleaner now. Added a description. |
dgozman
reviewed
Aug 3, 2021
Seems ok, but also not too useful. Let's check what others think.
mxschmitt
approved these changes
Aug 4, 2021
We have some code in utils.js where we override class HashStream extends stream.Writable {
private _hash = crypto.createHash('sha1');
override _write(chunk: Buffer, encoding: string, done: () => void) {
this._hash.update(chunk);
done();
}
digest(): string {
return this._hash.digest('hex');
}
} We can always turn it off if people don't like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TypeScript added a feature to force all overrides to be marked as such. We use to do this in the DevTools days with
@override
. We can land it if we like how it looks.The text was updated successfully, but these errors were encountered: