[tf.data] graduate choose_from_datasets API from experimental to tf.data.Dataset #51753
+150
−38
Conversation
kvignesh1420
force-pushed the
kvignesh1420:graduate-choose-from-datasets
branch
from
b9f00a5
to
7332255
|
Thanks @kvignesh1420 |
| to set it to `True`. Otherwise, the selected elements start off as | ||
| the user intends, but may change as input datasets become empty. | ||
| This can be difficult to detect since the dataset starts off looking | ||
| correct. Default to `False` for backward compatibility. |
aaudiber
Sep 2, 2021
Contributor
Can we make the default True now? The backward compatibility requirement no longer applies since we are migrating the API. We need to call out the change in default in the release notes and deprecation message, and tell users to set stop_on_empty_dataset=False to get the same as the experimental API.
We should do the same for sample_from_datasets, in a separate CL.
kvignesh1420
Sep 2, 2021
Author
Member
@aaudiber I agree. I have made the necessary changes. Please take a look.
add tf.data breaking changes to RELEASE.md fix api compatibility test failure fix api compatibility test failures
kvignesh1420
force-pushed the
kvignesh1420:graduate-choose-from-datasets
branch
from
bcb8fe2
to
1b0f897
|
@aaudiber can you please approve the pull request again? |
|
@aaudiber looks like there is an internal check failure. Anything that I can help with? Just wanted to get this merged before the dataset_ops refactor |
copybara-service
bot
merged commit 93d8e92
into
tensorflow:master
11 of 15 checks passed
11 of 15 checks passed
feedback/copybara
Google internal checks FAILED for runs with create time 2021-09-10T10:49:39.544436986Z.
Details
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR graduates the
tf.data.experimental.choose_from_datasetsAPI intotf.data.Dataset.choose_from_datasetsby making the following changes:choose_from_datasets()method to DatasetV2 class.cc: @aaudiber