-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] Add swiss roll with hole dataset #20950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added the option for creating the swiss roll with hole dataset in the make_swiss_roll() function.
is there any related issue related to this enhancement? |
@glemaitre No, I have not seen an issue related to this. I'm working on comparing various non-linear dimensionality reduction algorithms and wanted to use the swiss roll and swiss roll with hole data. The swiss roll with hole is a classic dataset for evaluating non-linear dimensionality reduction and I felt that it's important to include the option to create it. |
Could you please update/extend one of the existing examples to demonstrate how manifold learning models of scikit-learn behave on this dataset? For instance, the following example could be extended into a multi-stage example (first without the hole and then with the hole): This example dates from a long time ago, before sphinx-gallery had support for notebook style examples. Nowadays we would write multi-step examples with the |
@ogrisel Sure, I'll give it a try and update when done. |
Updated Swiss Roll example to include Swiss-hole and improved the general look of the example.
@ogrisel Sorry for the delay. I have updated the example as requested and also included a comparison to t-SNE. Let me know if there's anything else I can do. |
For some reason, CircleCi did gave the error: "AttributeError: Unknown property auto_add_to_figure", so I changed the method of creating the 3d plot.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?