Skip to content

[MRG] Add swiss roll with hole dataset #20950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

[MRG] Add swiss roll with hole dataset #20950

wants to merge 14 commits into from

Conversation

pujaltes
Copy link
Contributor

@pujaltes pujaltes commented Sep 6, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Added the option for creating the swiss roll with hole dataset in the make_swiss_roll() function.
@glemaitre
Copy link
Member

is there any related issue related to this enhancement?

@pujaltes
Copy link
Contributor Author

pujaltes commented Sep 6, 2021

@glemaitre No, I have not seen an issue related to this.

I'm working on comparing various non-linear dimensionality reduction algorithms and wanted to use the swiss roll and swiss roll with hole data. The swiss roll with hole is a classic dataset for evaluating non-linear dimensionality reduction and I felt that it's important to include the option to create it.

@pujaltes pujaltes marked this pull request as draft September 6, 2021 23:57
@pujaltes pujaltes closed this Sep 7, 2021
@pujaltes pujaltes reopened this Sep 7, 2021
@pujaltes pujaltes marked this pull request as ready for review September 7, 2021 00:17
@ogrisel
Copy link
Member

ogrisel commented Sep 8, 2021

Could you please update/extend one of the existing examples to demonstrate how manifold learning models of scikit-learn behave on this dataset?

For instance, the following example could be extended into a multi-stage example (first without the hole and then with the hole):

https://scikit-learn.org/stable/auto_examples/manifold/plot_swissroll.html#sphx-glr-auto-examples-manifold-plot-swissroll-py

This example dates from a long time ago, before sphinx-gallery had support for notebook style examples. Nowadays we would write multi-step examples with the # %% cell separation marker. For instance look at for an example with a modern layout: https://scikit-learn.org/dev/auto_examples/applications/plot_cyclical_feature_engineering.html

@pujaltes
Copy link
Contributor Author

pujaltes commented Sep 9, 2021

@ogrisel Sure, I'll give it a try and update when done.

@pujaltes pujaltes marked this pull request as draft September 9, 2021 02:23
Updated Swiss Roll example to include Swiss-hole and improved the general look of the example.
@pujaltes pujaltes marked this pull request as ready for review October 9, 2021 06:43
@pujaltes
Copy link
Contributor Author

pujaltes commented Oct 9, 2021

@ogrisel Sorry for the delay.

I have updated the example as requested and also included a comparison to t-SNE. Let me know if there's anything else I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants