Skip to content

[Lock] Add types to private properties #42928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2021
Merged

[Lock] Add types to private properties #42928

merged 1 commit into from
Sep 9, 2021
+53 −61

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 8, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@derrabus derrabus requested a review from jderusse as a code owner September 8, 2021 08:15
@carsonbot carsonbot added this to the 6.0 milestone Sep 8, 2021
derrabus
derrabus commented Sep 8, 2021
View reviewed changes
@carsonbot
Copy link

Hey!

I think @rvitaliy has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus
[Lock] Add types to private properties
6cd1b37 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the types/lock-properties branch from 9257d44 to 6cd1b37 Compare September 9, 2021 09:32
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 09e0ce0 into symfony:6.0 Sep 9, 2021
@derrabus derrabus deleted the types/lock-properties branch September 9, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Lock Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @carsonbot @nicolas-grekas