Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Support rediss in transport bridge #42932

Merged

Conversation

RuslanZavacky
Copy link
Contributor

@RuslanZavacky RuslanZavacky commented Sep 8, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR

Seems like support for rediss was added in the main package, but didn't propagate to the bridge

Followed a trail from here - #39607

@carsonbot
Copy link

carsonbot commented Sep 8, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@RuslanZavacky RuslanZavacky changed the base branch from 5.4 to 5.3 Sep 8, 2021
@RuslanZavacky RuslanZavacky changed the base branch from 5.3 to 5.4 Sep 8, 2021
@RuslanZavacky
Copy link
Contributor Author

RuslanZavacky commented Sep 8, 2021

Feels like I might've opened it to the wrong initial branch, probably the lowest should be as 5.3, if that's the case, let me know and I can redo this one :)

@RuslanZavacky
Copy link
Contributor Author

RuslanZavacky commented Sep 8, 2021

Test failure doesn't seem to be relevant, or I am missing something?

@carsonbot carsonbot changed the title Support rediss in transport bridge [Messenger] Support rediss in transport bridge Sep 8, 2021
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

(for 5.3)

@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 5.3 Sep 8, 2021
@nicolas-grekas nicolas-grekas force-pushed the support-rediss-in-transport-bridge branch from ce7dceb to edfad64 Compare Sep 8, 2021
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 8, 2021

Thank you @RuslanZavacky.

@nicolas-grekas nicolas-grekas merged commit 3cf8234 into symfony:5.3 Sep 8, 2021
9 of 11 checks passed
@fabpot fabpot mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants