Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45156: fixes inifite loop on mock.seal() #28300

Merged
merged 7 commits into from Sep 14, 2021
Merged

bpo-45156: fixes inifite loop on mock.seal() #28300

merged 7 commits into from Sep 14, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 12, 2021 •
edited by bedevere-bot

@sobolevn sobolevn requested a review from cjw296 as a code owner Sep 12, 2021
@tirkarthi
Copy link
Member

tirkarthi commented Sep 12, 2021

cc @mariocj89

corona10
corona10 reviewed Sep 13, 2021
View changes
Lib/unittest/mock.py Outdated Show resolved Hide resolved
sobolevn and others added 5 commits Sep 13, 2021
@sobolevn @corona10
Update Lib/unittest/mock.py
3c87eea 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn @corona10
Update Misc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst
1b70cd4 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn @corona10
Update Misc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst
8238aec 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn
Fixes typo
9fb0b33
@sobolevn
Fixes typo
b156248
@sobolevn
Copy link
Member Author

sobolevn commented Sep 13, 2021

@corona10 fixed! Thanks a lot for your help!

mariocj89
mariocj89 approved these changes Sep 14, 2021
View changes
Copy link
Contributor

@mariocj89 mariocj89 left a comment

Thanks for submitting this!

@vstinner vstinner merged commit 7f60c9e into python:main Sep 14, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 14, 2021

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 14, 2021

GH-28326 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2021
@sobolevn @miss-islington
bpo-45156: Fixes inifite loop on unittest.mock.seal() (pythonGH-28300)
50abca7 
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington
Copy link
Contributor

miss-islington commented Sep 14, 2021

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 14, 2021

GH-28327 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2021
@sobolevn @miss-islington
bpo-45156: Fixes inifite loop on unittest.mock.seal() (pythonGH-28300)
2e3c19a 
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner
Copy link
Member

vstinner commented Sep 14, 2021

Thanks @sobolevn for the fix. I trust @mariocj89 for the review, so I merged the PR ;-)

@sobolevn
Copy link
Member Author

sobolevn commented Sep 14, 2021

Thanks everyone!

miss-islington added a commit that referenced this pull request Sep 14, 2021
@miss-islington @sobolevn
bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300)
13257d9 
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Sep 14, 2021
@miss-islington @sobolevn
bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300) (GH-…
fd74d26 
…28326)

Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@mariocj89 mariocj89

@cjw296 cjw296

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sobolevn @tirkarthi @miss-islington @bedevere-bot @vstinner @cjw296 @mariocj89 @corona10 @the-knights-who-say-ni