Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-5846: Do not use obsolete unittest functions. #28303

Merged
merged 1 commit into from Sep 13, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 13, 2021

Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.

https://bugs.python.org/issue5846

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Please use defaultTestLoader instead of creating a new instance whenever possible.

Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.
@serhiy-storchaka serhiy-storchaka merged commit 851811f into python:main Sep 13, 2021
11 checks passed
@serhiy-storchaka serhiy-storchaka deleted the unittest-makesuite branch Sep 13, 2021
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants