Skip to content

/ pygame

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test: display.gl_set_attribute() #1748

Open
MyreMylar opened this issue May 16, 2020 · 14 comments
Open

Add unit test: display.gl_set_attribute() #1748

MyreMylar opened this issue May 16, 2020 · 14 comments
Assignees
@FizzyBerry
Labels
Difficulty: Easy display good first issue needs-tests python code

Comments

@MyreMylar
Copy link
Contributor

@MyreMylar MyreMylar commented May 16, 2020 •
edited by ankith26

This function needs a unit test.

Guide to how to contribute to an open source project on GitHub.

Test stub: https://github.com/pygame/pygame/blob/main/test/display_test.py#L255-L274
Docs: https://www.pygame.org/docs/ref/display.html#pygame.display.gl_set_attribute
Code to be tested: https://github.com/pygame/pygame/blob/main/src_c/display.c#L774-L787
@jtoloff
Copy link
Contributor

@jtoloff jtoloff commented Jun 23, 2020

Hello, may I be assigned this issue?
@MyreMylar
Copy link
Contributor Author

@MyreMylar MyreMylar commented Jun 23, 2020

Assigned!
@JKolodny
Copy link

@JKolodny JKolodny commented Oct 2, 2020

If this issue is still open and not being worked on, could I have it assigned to me? Thanks!
@MyreMylar MyreMylar assigned JKolodny and unassigned jtoloff Oct 3, 2020
@MyreMylar
Copy link
Contributor Author

@MyreMylar MyreMylar commented Oct 3, 2020

Assigned! Good luck.
@FizzyBerry
Copy link

@FizzyBerry FizzyBerry commented Nov 20, 2020

Hello, can I be assigned as well?
@ankith26 ankith26 assigned FizzyBerry and unassigned JKolodny Nov 20, 2020
@ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 20, 2020

Assigned :)
👍
@FizzyBerry
Copy link

@FizzyBerry FizzyBerry commented Nov 25, 2020

Hello I just want to say that links for "code to be tested" and "test stub" are not pointing on the right part in code (instead of display.gl_set_attribute() they are pointing on get_surface() ) and it is misleading. It is probably because the code has changed since then.
@ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 25, 2020

Updated first post
@MyreMylar
Copy link
Contributor Author

@MyreMylar MyreMylar commented Nov 25, 2020

Yeah this was my fault for using links instead of the GitHub functionality to point at a chunk of code for all time.
@yac1n3
Copy link

@yac1n3 yac1n3 commented Dec 2, 2020

Hello, can I be assigned as well please ?
@JayroBoy
Copy link

@JayroBoy JayroBoy commented Dec 3, 2020

Hi, can I be assigned to this? I'd like to take a crack at it
@illume
Copy link
Member

@illume illume commented Dec 3, 2020

This new PR kind of addresses this. It's in progress here: #2375
@aaditkamat
Copy link

@aaditkamat aaditkamat commented Dec 28, 2020

Is the issue resolved?
@ankith26
Copy link
Member

@ankith26 ankith26 commented Dec 28, 2020 •
edited

No, I guess. The PR linked above, was for gl_get_attribute, and there haven’t been any tests written for gl_set_attribute yet
anesantos added a commit to anesantos/pygame that referenced this issue Apr 10, 2021
@anesantos
Add unit test: display.gl_set_attribute() pygame#1748
118065d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FizzyBerry FizzyBerry

Labels
Difficulty: Easy display good first issue needs-tests python code
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
@illume @MyreMylar @JKolodny @JayroBoy @aaditkamat @ankith26 @FizzyBerry @jtoloff @yac1n3