Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyFile on Windows is Slow #3116

Open
jasnell opened this issue Feb 22, 2021 · 3 comments
Open

CopyFile on Windows is Slow #3116

jasnell opened this issue Feb 22, 2021 · 3 comments
Labels
good first issue help wanted windows

Comments

@jasnell
Copy link
Contributor

@jasnell jasnell commented Feb 22, 2021

See original issue and associated discussion in Node.js issue tracker here: nodejs/node#36158

/cc @asklar, @aduh95, @bzoz
@jasnell jasnell mentioned this issue Feb 22, 2021
Closed
@stale stale bot added the stale label Mar 20, 2021
@asklar
Copy link

@asklar asklar commented Mar 20, 2021

Is there any interest from the libuv maintainers to pursue this?

@stale stale bot removed the stale label Mar 20, 2021
@libuv libuv deleted a comment from stale bot Mar 21, 2021
@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Mar 21, 2021

I've added labels. Pull request welcome.

RaisinTen added a commit to RaisinTen/libuv that referenced this issue Mar 21, 2021
@RaisinTen
win, fs: use CopyFileExW instead of CopyFile
9ff4212 
Fixes: libuv#3116
@RaisinTen RaisinTen mentioned this issue Mar 21, 2021
Closed
@RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Mar 21, 2021

PR: #3135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted windows
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

win, fs: use CopyFileExW instead of CopyFile
4 participants
@bnoordhuis @jasnell @asklar @RaisinTen