Skip to content

Generate KIC tool versions for website on KIC Base release #12030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Generate KIC tool versions for website on KIC Base release #12030

wants to merge 6 commits into from

Conversation

andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Jul 21, 2021 •
edited
Loading

Partially completes #11435. Still need to do ISO.

Kicbase Dockerfile creates /tools.csv containing the versions of all tools. Kicbase release script then extracts this file and uses it to generate the web page.

image

Note: crictl has unknown version due to a bug in the binary itself. See kubernetes-sigs/cri-tools#798 for more

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andriyDev
To complete the pull request process, please assign spowelljr after the PR has been reviewed.
You can assign the PR to them by writing /assign @spowelljr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from blueelvis and prezha July 21, 2021 17:23
@andriyDev andriyDev force-pushed the AutoGenToolVersions branch from 093d43c to d567a92 Compare July 21, 2021 17:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2021
@medyagh
Copy link
Member

medyagh commented Jul 21, 2021

seems empty here https://deploy-preview-12030--kubernetes-sigs-minikube.netlify.app/docs/releaseinfo/kictoolversions/

@andriyDev andriyDev force-pushed the AutoGenToolVersions branch from d567a92 to 7e2e6c0 Compare July 21, 2021 20:25
@andriyDev
Copy link
Contributor Author

@medyagh I manually backfilled for the current kicbase.

@andriyDev andriyDev changed the title Generate KIC tool versions for website on KIC Base release [wip] Generate KIC tool versions for website on KIC Base release Jul 22, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2021
@andriyDev andriyDev force-pushed the AutoGenToolVersions branch from 7e2e6c0 to 0ab8c33 Compare July 22, 2021 20:24
@andriyDev andriyDev force-pushed the AutoGenToolVersions branch from 0ab8c33 to 3c7a564 Compare July 22, 2021 20:40
@andriyDev
Copy link
Contributor Author

Moved all the version collection commands to a single script. This reduces the number of layers in the image, simplifies management, and makes version collection reusable.

@andriyDev andriyDev changed the title [wip] Generate KIC tool versions for website on KIC Base release Generate KIC tool versions for website on KIC Base release Jul 22, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2021
@sharifelgamal
Copy link
Collaborator

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @andriyDev, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

@andriyDev: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@andriyDev: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

@andriyDev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-minikube-build 276bdd0 link /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

medyagh
medyagh requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather we don't make kic a unique case
For sake of better maintenaniablity let's just start minikube and spit out versions for docker and a vm driver in automation

@medyagh medyagh closed this Sep 28, 2021
@medyagh
Copy link
Member

medyagh commented Sep 28, 2021

Skipping this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andriyDev @k8s-ci-robot @medyagh @sharifelgamal @minikube-bot