Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45125: Improves pickling docs and tests for shared_memory #28294

Merged
merged 4 commits into from Oct 1, 2021
Merged

bpo-45125: Improves pickling docs and tests for shared_memory #28294

merged 4 commits into from Oct 1, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 11, 2021 •
edited by bedevere-bot

@sobolevn sobolevn requested a review from tiran as a code owner Sep 11, 2021
@sobolevn
Copy link
Member Author

sobolevn commented Sep 11, 2021

Oh, I forgot about pickle protocols. ⏳

@sobolevn
Copy link
Member Author

sobolevn commented Sep 13, 2021 •
edited

@serhiy-storchaka I think that this is ready for the first round of review 👍
Would you, please?
Related #28182

@sobolevn
Copy link
Member Author

sobolevn commented Sep 23, 2021

@serhiy-storchaka friendly ping 🙂

serhiy-storchaka
serhiy-storchaka requested changes Sep 30, 2021
View changes
Lib/test/_test_multiprocessing.py Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Outdated
self.assertEqual(
bytes(sms.buf[0:6]), bytes(sms2.buf[0:6]), b'pickle')
Copy link
Member

@serhiy-storchaka serhiy-storchaka Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It perhaps does not work as you expected. The third argument is a message and usually should be string.

Copy link
Member Author

@sobolevn sobolevn Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's not how I expected this to work! TIL 👍

Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn
Copy link
Member Author

sobolevn commented Oct 1, 2021

@serhiy-storchaka thanks a lot! I've also rebased this onto the latest main.

I have made the requested changes; please review again (to make bot happy).

@bedevere-bot
Copy link

bedevere-bot commented Oct 1, 2021

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Oct 1, 2021
View changes
Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved
@sobolevn
Copy link
Member Author

sobolevn commented Oct 1, 2021

Oups, done 🙂

serhiy-storchaka
serhiy-storchaka approved these changes Oct 1, 2021
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 746d648 into python:main Oct 1, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Oct 1, 2021

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 1, 2021

GH-28675 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2021
@sobolevn @miss-islington
bpo-45125: Improves pickling docs and tests for shared_memory (pyth…
1a79cfa 
…onGH-28294)

(cherry picked from commit 746d648)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 1, 2021
@miss-islington @sobolevn
bpo-45125: Improves pickling docs and tests for shared_memory (GH-2…
fc3511f 
…8294)

(cherry picked from commit 746d648)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@tiran tiran

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
needs backport to 3.9 tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sobolevn @bedevere-bot @miss-islington @serhiy-storchaka @the-knights-who-say-ni