Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility check for Python versions below 2.2 in platform.libc_ver() #28314

Merged
merged 2 commits into from Sep 17, 2021

Conversation

@thedrow
Copy link
Contributor

@thedrow thedrow commented Sep 13, 2021

os.path.realpath() already exists in all our supported Python versions.
There's no longer a need to check if it exists or not.

`os.path.realpath()` already exists in all our supported Python versions.
There's no longer a need to check if it exists or not.
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Sep 13, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@thedrow

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@thedrow
Copy link
Contributor Author

@thedrow thedrow commented Sep 15, 2021

I have signed the CLA as requested.

Copy link
Contributor

@sobolevn sobolevn left a comment

Hi, @thedrow! 👋

Yes, the last commit was 15 years ago.
Снимок экрана 2021-09-16 в 1 16 20

@ambv ambv merged commit 778b075 into python:main Sep 17, 2021
11 checks passed
11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210917.37 succeeded
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
pablogsal added a commit to pablogsal/cpython that referenced this pull request Sep 17, 2021
…8314)

`os.path.realpath()` already exists in all our supported Python versions.
There's no longer a need to check if it exists or not.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Sep 17, 2021
…8314)

`os.path.realpath()` already exists in all our supported Python versions.
There's no longer a need to check if it exists or not.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Sep 19, 2021
…8314)

`os.path.realpath()` already exists in all our supported Python versions.
There's no longer a need to check if it exists or not.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@thedrow thedrow deleted the thedrow:patch-1 branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants