Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet #28354

Merged
merged 1 commit into from Sep 15, 2021
Merged

bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet #28354

merged 1 commit into from Sep 15, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 15, 2021 •
edited by bedevere-bot

test_pdb.test_checkline_is_not_executable() no longer writes output
to stdout.

Remove also unused variables 'f'.

https://bugs.python.org/issue45208

@vstinner
bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet
583c1af 
test_pdb.test_checkline_is_not_executable() no longer writes output
to stdout.

Remove also unused variables 'f'.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 15, 2021
@ambv ambv merged commit e08e491 into python:main Sep 15, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 15, 2021

Thanks @vstinner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 15, 2021

Sorry, @vstinner and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e08e491a6ceea8ca105612df10147418c4e105b8 3.9

@bedevere-bot
Copy link

bedevere-bot commented Sep 15, 2021

GH-28363 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2021
@vstinner @miss-islington
bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet (py…
021298f 
…thonGH-28354)

test_pdb.test_checkline_is_not_executable() no longer writes output
to stdout.

Remove also unused variables 'f'.
(cherry picked from commit e08e491)

Co-authored-by: Victor Stinner <vstinner@python.org>
ambv pushed a commit that referenced this pull request Sep 15, 2021
@miss-islington @vstinner
bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet (GH…
0e4f913 
…-28354) (GH-28363)

test_pdb.test_checkline_is_not_executable() no longer writes output
to stdout.

Remove also unused variables 'f'.
(cherry picked from commit e08e491)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner deleted the test_pdb branch Sep 16, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 16, 2021

GH-28381 is a backport of this pull request to the 3.9 branch.

vstinner added a commit that referenced this pull request Sep 16, 2021
@vstinner
bpo-45208: Make test_pdb.test_checkline_is_not_executable() quiet (GH…
471b381 
…-28354) (GH-28381)

test_pdb.test_checkline_is_not_executable() no longer writes output
to stdout.

Remove also unused variables 'f'.

(cherry picked from commit e08e491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vstinner @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni