Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45212: Add a comment for time.sleep() in tests #28414

Merged
merged 2 commits into from
Sep 17, 2021
Merged

bpo-45212: Add a comment for time.sleep() in tests #28414

merged 2 commits into from
Sep 17, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2021 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Sep 17, 2021
@ambv ambv self-requested a review September 17, 2021 10:48
vstinner
vstinner approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I just suggest to mention the bpo to ease future code reviews.

Lib/test/test_socket.py Outdated Show resolved Hide resolved
@serhiy-storchaka @vstinner
Update Lib/test/test_socket.py
5024921 
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka serhiy-storchaka merged commit 54a1760 into python:main Sep 17, 2021
@serhiy-storchaka serhiy-storchaka deleted the test-socket-sleep-comment branch September 17, 2021 13:20
@vstinner
Copy link
Member

Thank you for adding the comment :-)

@serhiy-storchaka
Copy link
Member Author

Thanks Łukasz.

niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@serhiy-storchaka @vstinner @niyas-sait
bpo-45212: Add a comment for time.sleep() in tests (pythonGH-28414)
0fba3af 
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@ambv ambv ambv approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @vstinner @ambv @the-knights-who-say-ni @bedevere-bot