Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset #28435

Merged
merged 2 commits into from Sep 17, 2021
Merged

bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset #28435

merged 2 commits into from Sep 17, 2021
+6 −2

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Sep 17, 2021 •
edited by miss-islington

This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).

https://bugs.python.org/issue45183

Automerge-Triggered-By: GH:brettcannon
@brettcannon
bpo-45183: don't raise an exception when calling zipimport.find_spec(…
58b557e 
…) when a zip file is missing and the internal cache has been reset
@brettcannon brettcannon changed the title bpo-45183: don't raise an exception when calling zipimport.find_spec() when a zip file is missing and the internal cache has been reset bpo-45183: don't raise an exception when calling zipimport.find_spec() when the zip file is missing and the internal cache has been reset Sep 17, 2021
@brettcannon brettcannon changed the title bpo-45183: don't raise an exception when calling zipimport.find_spec() when the zip file is missing and the internal cache has been reset bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset Sep 17, 2021
@brettcannon
Clarify news entry
94da755
@brettcannon brettcannon merged commit 209b703 into main Sep 17, 2021
12 checks passed
@brettcannon brettcannon deleted the zipimport-find_spec-no-zip branch Sep 17, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 17, 2021

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 17, 2021

GH-28437 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Sep 17, 2021
@brettcannon @miss-islington
bpo-45183: don't raise an exception when calling zipimport.zipimporte…
7b0f076 
…r.find_spec() when the zip file is missing and the internal cache has been reset (pythonGH-28435)

This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).
(cherry picked from commit 209b7035f714dcc41df054b0b023e0b955d7e1a2)

Co-authored-by: Brett Cannon <brett@python.org>
brettcannon added a commit to brettcannon/cpython that referenced this issue Sep 18, 2021
@brettcannon
[3.10] bpo-45183: don't raise an exception when calling zipimport.zip…
70d7877 
…importer.find_spec() when the zip file is missing and the internal cache has been reset (pythonGH-28435)

This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).
(cherry picked from commit 209b703)

Co-authored-by: Brett Cannon <brett@python.org>
brettcannon added a commit that referenced this issue Sep 18, 2021
@brettcannon
[3.10] bpo-45183: don't raise an exception when calling zipimport.zip…
e1bdecb 
…importer.find_spec() when the zip file is missing and the internal cache has been reset (GH-28435) (#28438)

This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).
(cherry picked from commit 209b703)

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou

@ericsnowcurrently ericsnowcurrently

@ncoghlan ncoghlan

@warsaw warsaw

Assignees
No one assigned
Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
4 participants
@brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni